Fix when dataset for connection not passed on #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jefferis
commented
Sep 10, 2022
jefferis
commented
- if you have a connection object with an associated dataset this should be used insted of the default dataset
- this is why check_dataset(dataset, conn=conn) is used in all other locations in the package
- this change fixes that omission in neuprint_connection_table
* if you have a connection object with an associated dataset this should be used insted of the default dataset * this is why check_dataset(dataset, conn=conn) is used in all other locations in the package * this change fixes that omission in neuprint_connection_table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.