Basic implementation and test for connection threshold #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jefferis
commented
Jul 30, 2020
jefferis
commented
- note that checkmate was already an indirect dependency
- @romainFr any comments? Also what do you think should happen when we have specified an ROI? Should the threshold apply to the total connectivity or to the ROI connectivity alone? Right now it is the former but I suspect it should be the latter ...
|
Useful addition, thanks! I do agree that the filter should be on ROI weight -- we've been thresholding mostly on ROI weight in our analysis. Alternatively, one could have one threshold for the ROI and one threshold for the neuron? |
OK.
I think I would probably keep it simple. Part of my motivation was just to avoid transferring a lot of n=1 or 2 connections. I think people can add secondary threshold criteria themselves if they want. |
* note that checkmate was already an indirect dependency
* the cypher got a bit hairy so I actually only apply the ROI weight threshold to downloaded data. * I'm sure there must be a way to apply it on the server in a multi-level query.
jefferis
force-pushed
the
feature/connection-table-threshold
branch
from
c08da3e to
2b4592e
Compare
* this is just to ensure consistency after various changes in dplyr/tibble that more aggressively return tibbles (which are nice but ...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.