-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an argument to bypass roi checks #103
Conversation
…step (for experimental ROIs not listed in the metadata)
Thank you @romainFr. Can you tell me more about these "hidden" ROIs. Is there no API call that will tell you about them? |
@jefferis They are fields of Neuron nodes/ roiInfo objects, but that's about it, they don't appear anywhere else to my knowledge. |
I was just wondering if there was some way at all we could update the roicheck function to find them as the check can be memoised so as long as there is at least one API call that returns this info. It could be combined with the existing API call to find the regular ROIs. Can you give this a bit of thought before we merge? |
Ah yes, I see what you mean. One can probably get at it with slight modifications of neuprint_get_fields. I'll give it a try |
…ead of the dataset metadata
So I did just that by tweaking |
As for default arguments, for now I chose to have |
Thanks for the suggestion @jefferis , that's much better than my clunky |
This is because we sometimes have experimental ROIs defined, but not loaded into the neuprint metadata (so called "hidden" rois). If some expert user want to access them, they can now use
roi_check=FALSE
in the relevant functions.