Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an argument to bypass roi checks #103

Merged
merged 15 commits into from
Mar 24, 2020
Merged

Add an argument to bypass roi checks #103

merged 15 commits into from
Mar 24, 2020

Conversation

romainFr
Copy link
Collaborator

This is because we sometimes have experimental ROIs defined, but not loaded into the neuprint metadata (so called "hidden" rois). If some expert user want to access them, they can now use roi_check=FALSE in the relevant functions.

@jefferis
Copy link
Contributor

Thank you @romainFr. Can you tell me more about these "hidden" ROIs. Is there no API call that will tell you about them?

@romainFr
Copy link
Collaborator Author

@jefferis They are fields of Neuron nodes/ roiInfo objects, but that's about it, they don't appear anywhere else to my knowledge.

@jefferis
Copy link
Contributor

I was just wondering if there was some way at all we could update the roicheck function to find them as the check can be memoised so as long as there is at least one API call that returns this info. It could be combined with the existing API call to find the regular ROIs. Can you give this a bit of thought before we merge?

@romainFr
Copy link
Collaborator Author

Ah yes, I see what you mean. One can probably get at it with slight modifications of neuprint_get_fields. I'll give it a try

@romainFr
Copy link
Collaborator Author

So I did just that by tweaking neuprint_get_fields to make it a bit more flexible. I also added a fromNeuronFields argument to neuprint_ROIs and neuprint_check_rois. Since neuprint_get_fields inside query is already memoised, we get that for free.

@romainFr
Copy link
Collaborator Author

As for default arguments, for now I chose to have neuprint_ROIs with the old behavior (as it allows to check for superLevelROIs separately), but neuprint_check_roi with the new behavior.

@romainFr
Copy link
Collaborator Author

Thanks for the suggestion @jefferis , that's much better than my clunky check_roi

@romainFr romainFr merged commit 823a15b into master Mar 24, 2020
@jefferis jefferis deleted the roi_check branch April 5, 2020 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants