-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add connectivity and basic metadata support for banc #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jefferis
commented
Aug 11, 2024
•
edited
Loading
edited
- Some of the guts of banc_meta should probably be moved out to fancr/bancr
- basic type/class queries are provided
* and list all neurons
* note fetching partner metadata is not clever * doing this because otherwise i had problems with expired ids - need to figure out why ... * hmm actually use last materialisation version everywhere
* we should probably move this and valid_ids to coconat as exported objects
* also increases fafbseg version requirement
* some unrelated readme changes that we may as well bring in
* if our ids are always in the state of the latest materialisation, but we use live live queries to get the latest contents of the cell_info table then we can run into issues when some ids from the latest version are out of date compared with live live. This in turn means that we cannot use filter_in_dict anymore
* i.e. if two neurons have the same set of types, at least let them appear together
* if two people have annotated the same neuron with the same type but in one case have left a ? then remove the ?
* also added as a repo secret for actions
* in particular with_banc will already error if there is no banc access.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.