Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add humble CI #40

Merged
merged 13 commits into from
May 16, 2024
Merged

Add humble CI #40

merged 13 commits into from
May 16, 2024

Conversation

Cakem1x
Copy link
Member

@Cakem1x Cakem1x commented May 15, 2024

This PR adds a Github Action for CI, based upon actions from ros-tooling.

It will check that

  • we have all dependencies specified
    • deps are installed via rosdep apt
    • for deps not available this way, we can add them to the source_dependencies.yaml file. Caveat: This will increase build times, since all packages in this repo will get build and tested.
  • build of workspace succeeds
  • workspace consisting of mesh_tools and repos from source_dependencies.yaml
  • test of workspace succeeds

Check out this action log, for example, if you want to see more details.

@Cakem1x Cakem1x marked this pull request as ready for review May 15, 2024 13:44
@Cakem1x Cakem1x changed the title Feature/add humble ci (WIP) humble CI May 15, 2024
@Cakem1x Cakem1x changed the base branch from humble to ros2-release May 16, 2024 11:52
Base automatically changed from ros2-release to humble May 16, 2024 12:04
@Cakem1x Cakem1x self-assigned this May 16, 2024
@Cakem1x Cakem1x requested a review from amock May 16, 2024 12:12
@Cakem1x Cakem1x changed the title (WIP) humble CI Add humble CI May 16, 2024
@Cakem1x
Copy link
Member Author

Cakem1x commented May 16, 2024

Current job runtime is 10min. I think we can improve this, e.g. via caching or by tweaking the parameters, but I suggest doing that at a later in a separate PR if the need arises.

@amock
Copy link
Collaborator

amock commented May 16, 2024

Current job runtime is 10min. I think we can improve this, e.g. via caching or by tweaking the parameters, but I suggest doing that at a later in a separate PR if the need arises.

Wow, that's long. But ok for now.

@Cakem1x
Copy link
Member Author

Cakem1x commented May 16, 2024

Current job runtime is 10min. I think we can improve this, e.g. via caching or by tweaking the parameters, but I suggest doing that at a later in a separate PR if the need arises.

Wow, that's long. But ok for now.

Yes, I think we should look into

  • GitHub Action caching
  • Building only mesh_tools pkgs and its source deps
    • on CLI, you could do `colcon build --packages-up-to $(colcon list --base-paths $PATH_TO_MESH_TOOLS_REPO). Maybe there is an option that does a similar thing in the ci action
  • Testing only mesh_tools pkgs (and not its source deps)
    • e.g. via `colcon test --packages-select $(colcon list --base-paths $PATH_TO_MESH_TOOLS_REPO). Maybe there is an option that does a similar thing in the ci action

@Cakem1x Cakem1x merged commit 40d01bd into humble May 16, 2024
1 check passed
@Cakem1x Cakem1x deleted the feature/add-humble-ci branch May 16, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants