Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TESTS] removed old dev depedencies #223

Merged
merged 3 commits into from
Nov 2, 2023
Merged

[TESTS] removed old dev depedencies #223

merged 3 commits into from
Nov 2, 2023

Conversation

aricart
Copy link
Member

@aricart aricart commented Nov 2, 2023

[FIX] CJS portion of the bundle was not working as the nats.js was missing. This usage is only supported for testing as it requires shimming

[DEPS] removed old dev dependencies as they are not needed, made tests use websocket dev dependency

…ssing. This usage is only supported for testing as it requires shimming

[DEPS] removed old dev dependencies as they are not needed, made tests use `websocket` dev dependency
@aricart aricart temporarily deployed to CI November 2, 2023 23:10 — with GitHub Actions Inactive
@aricart aricart temporarily deployed to CI November 2, 2023 23:12 — with GitHub Actions Inactive
@aricart aricart temporarily deployed to CI November 2, 2023 23:12 — with GitHub Actions Inactive
Copy link

@sethjback sethjback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart temporarily deployed to CI November 2, 2023 23:16 — with GitHub Actions Inactive
@aricart aricart temporarily deployed to CI November 2, 2023 23:16 — with GitHub Actions Inactive
@aricart aricart merged commit a0154cf into main Nov 2, 2023
2 checks passed
@aricart aricart deleted the build-infra branch November 2, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants