Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

max_reconnects not configurable in ConnectOptions #1186

Closed
glueball opened this issue Dec 31, 2023 · 2 comments
Closed

max_reconnects not configurable in ConnectOptions #1186

glueball opened this issue Dec 31, 2023 · 2 comments
Assignees
@Jarema
Labels
defect Suspected defect such as a bug or regression

Comments

@glueball
Copy link
Contributor

Observed behavior

The ConectOptions struct has the max_reconnects field, defaulting to Some(60), but no method to configure it.

Expected behavior

A method .max_reconnects allows configuring the value.

Server and client version

async_nats 0.33

Host environment

N/A

Steps to reproduce

N/A
@glueball glueball added the defect Suspected defect such as a bug or regression label Dec 31, 2023
glueball pushed a commit to glueball/nats.rs that referenced this issue Dec 31, 2023
nats-io#1186 Configure max_reconnects
852cd1e
glueball added a commit to glueball/nats.rs that referenced this issue Dec 31, 2023
@glueball
nats-io#1186 Configure max_reconnects
c15a15a
@glueball glueball mentioned this issue Dec 31, 2023
Closed
@Jarema
Copy link
Member

Jarema commented Jan 2, 2024

Thanks for filling the issue and the PR!

Will be reviewed soon.

@Jarema Jarema self-assigned this Jan 2, 2024
@Jarema
Copy link
Member

Jarema commented Jan 3, 2024

Fixed in #1188

@Jarema Jarema closed this as completed Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jarema Jarema

Labels
defect Suspected defect such as a bug or regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1186 Configure max_reconnects glueball/nats.rs
2 participants
@glueball @Jarema