Simplified NATS client #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved functionality from NATS.Client package into NATS.Client.Simplified since We can't use NATS.Client package as it belongs to v1.
|
Comment without any direction: As awkward as the convention is, should we consider cases where (I'm fine either way just DAing here) |
|
|
rickdotnet
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Looks ok to me.
One thing I've been meaning to dive into is looking for gaps in documentation. PRs like this could include documentation that addresses cases such as folks wanting to remain AOT-friendly. Perhaps an article or some section in the docs.
Could also include documentation like you've mentioned about where the delineation is for projects that should be AOT-friendly. Either in CONTRIBUTING.md or the docs.
This was referenced Aug 23, 2024
Merged
mtmk
added a commit
that referenced
this pull request
Sep 17, 2024
* Fixed consume pending message calculation (#626) * ServiceProvider callback for NATS DI configuration (#619) * Nats web socket opts improvements (#623) * Fix various disposable issues (#625) * Make NuidWriter public (#618) * NatsOpts.ConfigureWebSocketOpts callback handler (#605) * Simplified NATS client (#607) * Update docs (#595) * Add default timeout to initial commands (#594) * Extensive logging for reconnect debugging (#593) * Add clear next step navigation to API index doc (#592) * Add NATS client implementation (#589)
Merged
mtmk
added a commit
that referenced
this pull request
Sep 17, 2024
* Fixed consume pending message calculation (#626) * ServiceProvider callback for NATS DI configuration (#619) * Nats web socket opts improvements (#623) * Fix various disposable issues (#625) * Make NuidWriter public (#618) * NatsOpts.ConfigureWebSocketOpts callback handler (#605) * Simplified NATS client (#607) * Update docs (#595) * Add default timeout to initial commands (#594) * Extensive logging for reconnect debugging (#593) * Add clear next step navigation to API index doc (#592) * Add NATS client implementation (#589)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We moved functionality from the
NATS.Clientpackage intoNATS.Client.Simplifiedbecause theNATS.Clientpackage belongs to v1 and cannot be used. While we could have used theNATS.Netpackage, doing so would create dependencies on all other packages. To avoid this, NATS.Net remains a meta package that pulls everything together, allowing developers the flexibility to pull in packages gradually if they choose to use the simplified package with minimal dependencies.There is one breaking change: the
NATS.Netpackage will now reference the ad-hoc JSON serialization package, which may affect AOT (Ahead-of-Time) publishing for certain use cases, though this is likely uncommon. It's crucial that we avoid using non-AOT-friendly APIs, such as ad-hoc JSON serialization, in the core library.