-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JetStream documentation and minor fixes #129
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed variable PubOpts Headers and ReplyTo * Added headers and replyTo params to Publish methods * Make all Opts classes (not structs) * Added default options for JS context
* API docs update
caleblloyd
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can re-generate and merge after #128 lands
# Conflicts: # src/NATS.Client.Core/INatsConnection.cs # src/NATS.Client.Core/NatsConnection.Publish.cs # src/NATS.Client.Core/NatsConnection.RequestReply.cs # src/NATS.Client.Core/NatsConnection.RequestSub.cs # src/NATS.Client.Core/NatsMsg.cs # src/NATS.Client.Core/NatsRequestExtensions.cs # src/NATS.Client.Core/NatsRequestManyExtensions.cs # src/NATS.Client.JetStream/NatsJSConsumer.cs # src/NATS.Client.JetStream/NatsJSContext.cs
mtmk
changed the title
Jetstream documentation and minor fixes
JetStream documentation and minor fixes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JetStream added to documentation site. Also includes minor API and namespace fixes.