Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JetStream documentation and minor fixes #129

Merged
merged 11 commits into from
Sep 13, 2023
Merged

JetStream documentation and minor fixes #129

merged 11 commits into from
Sep 13, 2023

Conversation

mtmk
Copy link
Collaborator

@mtmk mtmk commented Sep 12, 2023

JetStream added to documentation site. Also includes minor API and namespace fixes.

mtmk added 8 commits September 7, 2023 20:46
* Removed variable PubOpts Headers and ReplyTo
* Added headers and replyTo params to Publish methods
* Make all Opts classes (not structs)
* Added default options for JS context
* API docs update
@mtmk mtmk requested a review from caleblloyd September 12, 2023 11:22
@mtmk mtmk changed the title Jetstream documentation Jetstream documentation and minor fixes Sep 12, 2023
Copy link
Collaborator

@caleblloyd caleblloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can re-generate and merge after #128 lands

# Conflicts:
#	src/NATS.Client.Core/INatsConnection.cs
#	src/NATS.Client.Core/NatsConnection.Publish.cs
#	src/NATS.Client.Core/NatsConnection.RequestReply.cs
#	src/NATS.Client.Core/NatsConnection.RequestSub.cs
#	src/NATS.Client.Core/NatsMsg.cs
#	src/NATS.Client.Core/NatsRequestExtensions.cs
#	src/NATS.Client.Core/NatsRequestManyExtensions.cs
#	src/NATS.Client.JetStream/NatsJSConsumer.cs
#	src/NATS.Client.JetStream/NatsJSContext.cs
@mtmk mtmk changed the title Jetstream documentation and minor fixes JetStream documentation and minor fixes Sep 13, 2023
@mtmk mtmk merged commit fd1fd42 into main Sep 13, 2023
@mtmk mtmk deleted the jetstream-doce-update branch September 13, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants