Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetstream preview release 1 #126

Merged
merged 6 commits into from
Sep 7, 2023
Merged

Jetstream preview release 1 #126

merged 6 commits into from
Sep 7, 2023

Conversation

mtmk
Copy link
Collaborator

@mtmk mtmk commented Sep 6, 2023

  • Consume and fetch error handling removes
  • Consume and fetch now throws exception on JS terminal errors
  • Removed ErrorHandler option
  • Async enumerable initial List implementation
  • Domain option added to JSOpts
  • Logging improvements for testing
  • Option validations now throw exception

mtmk added 4 commits September 4, 2023 15:23
* Fixes to error handler interface
* Stream delete interface
Exposed list APIs respond object to make paging possible.
A paging extension can be implemented separately if needed.
* Consume and fetch error handling removes
* Consume and fetch now throws exception on JS terminal errors
* Removed ErrorHandler option
* Async enumerable initial List implementation
* Domain option added to JSOpts
* Logging improvements for testing
* Option validations now throw exception
@mtmk mtmk requested a review from caleblloyd September 6, 2023 19:34
Copy link
Collaborator

@caleblloyd caleblloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a couple small comments

src/NATS.Client.JetStream/NatsJSOpts.cs Outdated Show resolved Hide resolved
* Also fixed typo in NatsJSOptsDefaults
Copy link
Collaborator

@caleblloyd caleblloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtmk mtmk merged commit 295a636 into main Sep 7, 2023
@mtmk mtmk deleted the jetstream-preview-release-1 branch September 7, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants