-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NatsWebSocketOpts improvements #610
Milestone
Comments
Hi guys. |
thanks @Ivandemidov00 that would be great 👍💯 please tag @caleblloyd in your PR so he can review when he has time ;) edit: btw #605 is merged in case you missed it. |
Ivandemidov00
added a commit
to Ivandemidov00/nats.net.v2
that referenced
this issue
Aug 29, 2024
* Separate model NatsWebSocketOpts * Сalled NatsTlsOpts.AuthenticateAsClientAsync parameters before passing it to the ConfigureWebSocketOpts * RequestHeaders overwrite the header specified in ConfigureWebSocketOpts
Ivandemidov00
added a commit
to Ivandemidov00/nats.net.v2
that referenced
this issue
Aug 30, 2024
* Added test
Ivandemidov00
added a commit
to Ivandemidov00/nats.net.v2
that referenced
this issue
Sep 8, 2024
* Fence added, an occurs exceptions when add headers to blazor
caleblloyd
added a commit
to Ivandemidov00/nats.net.v2
that referenced
this issue
Sep 9, 2024
This reverts commit e6b9d1c.
mtmk
added a commit
that referenced
this issue
Sep 9, 2024
* NatsWebSocketOpts improvements (#610) * Separate model NatsWebSocketOpts * Сalled NatsTlsOpts.AuthenticateAsClientAsync parameters before passing it to the ConfigureWebSocketOpts * RequestHeaders overwrite the header specified in ConfigureWebSocketOpts * NatsWebSocketOpts improvements (#610) * Added test * Build fixes * Build fixes * Build fixes * dotnet format * #623 reccomendations Signed-off-by: Caleb Lloyd <[email protected]> * NatsWebSocketOpts improvements (#610) * Fence added, an occurs exceptions when add headers to blazor * Revert "NatsWebSocketOpts improvements (#610)" This reverts commit e6b9d1c. * WebSocketSecure tests Signed-off-by: Caleb Lloyd <[email protected]> * fix format Signed-off-by: Caleb Lloyd <[email protected]> * simplify WebSocketOptionsTest Signed-off-by: Caleb Lloyd <[email protected]> --------- Signed-off-by: Caleb Lloyd <[email protected]> Co-authored-by: Ziya Suzen <[email protected]> Co-authored-by: Caleb Lloyd <[email protected]>
divyeshio
pushed a commit
to divyeshio/nats.net
that referenced
this issue
Sep 13, 2024
* NatsWebSocketOpts improvements (nats-io#610) * Separate model NatsWebSocketOpts * Сalled NatsTlsOpts.AuthenticateAsClientAsync parameters before passing it to the ConfigureWebSocketOpts * RequestHeaders overwrite the header specified in ConfigureWebSocketOpts * NatsWebSocketOpts improvements (nats-io#610) * Added test * Build fixes * Build fixes * Build fixes * dotnet format * nats-io#623 reccomendations Signed-off-by: Caleb Lloyd <[email protected]> * NatsWebSocketOpts improvements (nats-io#610) * Fence added, an occurs exceptions when add headers to blazor * Revert "NatsWebSocketOpts improvements (nats-io#610)" This reverts commit e6b9d1c. * WebSocketSecure tests Signed-off-by: Caleb Lloyd <[email protected]> * fix format Signed-off-by: Caleb Lloyd <[email protected]> * simplify WebSocketOptionsTest Signed-off-by: Caleb Lloyd <[email protected]> --------- Signed-off-by: Caleb Lloyd <[email protected]> Co-authored-by: Ziya Suzen <[email protected]> Co-authored-by: Caleb Lloyd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A couple more ideas, which could be done in a follow-up before releasing:
NatsWebSocketOpts
instead of setting it directly inNatsOpts
? This could make it easier to offer a shortcuts for popular options such as adding headers:NatsTlsOpts.AuthenticateAsClientOptionsAsync
and copy bothClientCertificates
andRemoteCertificateValidationCallback
toClientWebSocketOptions
prior to passing it to the callbackOriginally posted by @caleblloyd in #605 (comment)
The text was updated successfully, but these errors were encountered: