Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easier access to timeout in JetStream implementations #1236

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

scottf
Copy link
Contributor

@scottf scottf commented Oct 8, 2024

JetStream implementation code relies on the the timeout, first from any supplied JetStreamOptions, second from connection options. This just simplifies, so code is not duplicated and can be retrieved via one method that understands the priority.

Copy link
Member

@MauriceVanVeen MauriceVanVeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottf scottf merged commit d263667 into main Oct 8, 2024
4 checks passed
@scottf scottf deleted the request-timeout-improvement branch October 8, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants