Add Direct Get by start time #1226
Conversation
Signed-off-by: Maurice van Veen <[email protected]>
| * server such as timeout or interruption | ||
| * @throws JetStreamApiException the request had an error related to the data | ||
| */ | ||
| MessageInfo getFirstMessage(String streamName, ZonedDateTime startTime) throws IOException, JetStreamApiException; |
There was a problem hiding this comment.
Is there ever a case when we will want first message by subject and start time? It's probably fine to have this since it seems like a common behavior, but I think it's time to expose something like
MessageInfo getMessage(String streamName, MessageGetRequest messageGetRequest)
There was a problem hiding this comment.
Added, in combination with the new builder.
There was a problem hiding this comment.
After some discussion offline removed the builder again, as the only combinations that needed to be added were:
getFirstMessage(streamName, startTime)getFirstMessage(streamName, startTime, subject)
And then we don't need extra validation in the builder for valid combinations.
| } | ||
|
|
||
| private MessageGetRequest(long sequence, String lastBySubject, String nextBySubject) { | ||
| private MessageGetRequest(long sequence, String lastBySubject, String nextBySubject, ZonedDateTime startTime) { |
There was a problem hiding this comment.
Probably should add a builder to this class, especially if we are going to add a generic get message api
There was a problem hiding this comment.
Added the builder 👍
There was a problem hiding this comment.
| @@ -1305,6 +1306,7 @@ private void validateGetMessage(JetStreamManagement jsm, TestingStreamContainer | |||
|
|
|||
| assertStatus(10003, assertThrows(JetStreamApiException.class, () -> jsm.getMessage(tsc.stream, -1))); | |||
| assertStatus(10003, assertThrows(JetStreamApiException.class, () -> jsm.getMessage(tsc.stream, 0))); | |||
| assertStatus(10003, assertThrows(JetStreamApiException.class, () -> jsm.getFirstMessage(tsc.stream, DEFAULT_TIME))); | |||
There was a problem hiding this comment.
Just curious, is it correct that this fails because the start time is before the very first message in the stream?
There was a problem hiding this comment.
This doesn't fail because of the start time being before the first message.
Instead it fails because a DEFAULT_TIME doesn't get serialized into the final JSON, resulting in an empty JSON object being sent which is checked here should be an error.
Signed-off-by: Maurice van Veen <[email protected]>
Signed-off-by: Maurice van Veen <[email protected]>
Signed-off-by: Maurice van Veen <[email protected]>
|
Drafting for now, needs a little more polish to capture the valid combinations in |
Signed-off-by: Maurice van Veen <[email protected]>
Signed-off-by: Maurice van Veen <[email protected]>
No description provided.