Fix #1125 NatsJetStreamMetaData timestamp timezone #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t timezone unable to convert back to UTC
|
@mrmx Good catch, thank you for the fix. |
scottf
requested changes
Apr 22, 2024
There was a problem hiding this comment.
Can you do 2 things...
1. Can you fix line 27 of NatsJetStreamMetaData.java from
private static final long NANO_FACTOR = 10_00_000_000;
to
private static final long NANO_FACTOR = 1_000_000_000;
2. Can you refactor lines 105-111 into DateTimeUtils as a function like parseTimestamp
Also, for future PR's can you please verify your commits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #1125 NatsJetStreamMetaData timestamp parsed with incorrect timezone unable to convert back to UTC