-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIXED] Change Fetch client timeout to a higher value #1689
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is an interesting approach, though I wonder if it makes sense - as the actual delay between timeout actually occuring and getting it by the client does not change depending on the timeout duration, just RTT.
Maybe we should agree on the OSS team what offset do we put here.
Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
20ea1d3
to
81bf320
Compare
Because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* [FIXED] Change Fetch client timeout to a higher value Signed-off-by: Piotr Piotrowski <[email protected]> * Set the maximum diff on timeouts Signed-off-by: Piotr Piotrowski <[email protected]> --------- Signed-off-by: Piotr Piotrowski <[email protected]>
* [FIXED] Change Fetch client timeout to a higher value Signed-off-by: Piotr Piotrowski <[email protected]> * Set the maximum diff on timeouts Signed-off-by: Piotr Piotrowski <[email protected]> --------- Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Piotr Piotrowski [email protected]