Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] Change Fetch client timeout to a higher value #1689

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

piotrpio
Copy link
Collaborator

Signed-off-by: Piotr Piotrowski [email protected]

@piotrpio piotrpio requested a review from Jarema July 31, 2024 10:31
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is an interesting approach, though I wonder if it makes sense - as the actual delay between timeout actually occuring and getting it by the client does not change depending on the timeout duration, just RTT.

Maybe we should agree on the OSS team what offset do we put here.

@piotrpio
Copy link
Collaborator Author

piotrpio commented Aug 2, 2024

Because Fetch() and FetchBatch() both accept context, it is not feasible to set the internal timeout to a value larger than expiry (which would make things easier). We cannot have a constant value when decrementing, that's why I went with 0.9 * ttl. This however is problematic with very large user timeouts, when the diff could potentially be minutes. I changed it now to saturate at 5s. For very low timeout values this will still be not very usable, but that's usually not a valid approach anyway.

Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piotrpio piotrpio merged commit af10233 into main Aug 12, 2024
3 of 4 checks passed
@piotrpio piotrpio deleted the increase-fetch-timeout branch August 12, 2024 07:33
@piotrpio piotrpio mentioned this pull request Aug 13, 2024
piotrpio added a commit that referenced this pull request Aug 15, 2024
* [FIXED] Change Fetch client timeout to a higher value

Signed-off-by: Piotr Piotrowski <[email protected]>

* Set the maximum diff on timeouts

Signed-off-by: Piotr Piotrowski <[email protected]>

---------

Signed-off-by: Piotr Piotrowski <[email protected]>
piotrpio added a commit that referenced this pull request Aug 15, 2024
* [FIXED] Change Fetch client timeout to a higher value

Signed-off-by: Piotr Piotrowski <[email protected]>

* Set the maximum diff on timeouts

Signed-off-by: Piotr Piotrowski <[email protected]>

---------

Signed-off-by: Piotr Piotrowski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants