Pause heartbeat detection during reconnection #1631
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @withinboredom, thanks for the contribution! Instead of pausing the heartbeat on reconnect, the proper behavior would be to pause it on disconnect (currently we were resetting it). I fixed this as part of this PR: #1643 Again, thank you for the contribution and sorry for not checking it earlier. |
|
@piotrpio, thanks for the comment and glad it resulted in a better fix! Should we close this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, reconnection may take many multiples of seconds to perform. However, heartbeat detection is still enabled during this period, making it extremely likely that the very first "message" after reconnection is a heartbeat failure.
This PR stops the heartbeat timer until a connection is successfully made.
Fixes #1622