[ADDED] KV implementation in new JetStream API #1362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Piotrowski <[email protected]>
piotrpio
force-pushed
the
port-kv-and-os-to-jetstream
branch
from
69db83a to
6fbc297
Compare
piotrpio
force-pushed
the
port-kv-and-os-to-jetstream
branch
2 times, most recently
from
29f6aee to
1572cd8
Compare
|
There are some errors in CI that should be addressed. |
Signed-off-by: Piotr Piotrowski <[email protected]>
piotrpio
force-pushed
the
port-kv-and-os-to-jetstream
branch
from
1572cd8 to
d5f5861
Compare
Co-authored-by: Tomasz Pietrek <[email protected]>
Co-authored-by: Tomasz Pietrek <[email protected]>
piotrpio
force-pushed
the
port-kv-and-os-to-jetstream
branch
from
1fc2581 to
7d25175
Compare
piotrpio
added a commit
that referenced
this pull request
Aug 25, 2023
Signed-off-by: Piotr Piotrowski <[email protected]>
piotrpio
added a commit
that referenced
this pull request
Aug 28, 2023
Signed-off-by: Piotr Piotrowski <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the KV implementation to new JetStream API.
This implementation uses ordered push consumer from legacy API to avoid breaking changes in subject permissions. Most of the implementation stays the same, but the API changed to be more in-line with the rest of
jetstreampackage (e.g. using context).