-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADDED] client support for multi-subject transforms in sources and mirrors #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfig.go Adds new multi-filter fields to StreamSource and StreamSourceInfo in jms.go and stream_config.go
…ter and subject transform fields when creating a stream, and add associated errors.
… 2.10 related source filter and subject transform fields when creating or updating a stream for the new JS API
Improves error message Update go_test.mod to point to the branch of nats-server with the multifilter sourcing changes
piotrpio
reviewed
Aug 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few nits
piotrpio
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
piotrpio
pushed a commit
that referenced
this pull request
Aug 26, 2023
piotrpio
pushed a commit
that referenced
this pull request
Sep 1, 2023
piotrpio
pushed a commit
that referenced
this pull request
Sep 1, 2023
piotrpio
pushed a commit
that referenced
this pull request
Sep 19, 2023
piotrpio
pushed a commit
that referenced
this pull request
Sep 19, 2023
piotrpio
pushed a commit
that referenced
this pull request
Sep 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See nats-io/nats-server#4276 and nats-io/nats-server#4354