Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for KV mirrors and sources. #1112

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Added support for KV mirrors and sources. #1112

merged 1 commit into from
Oct 20, 2022

Conversation

derekcollison
Copy link
Member

Also updated state for proper Put() and Get() semantics with mirrors and across domains, e.g. leafnodes.

In practice when a mirror is across a domain, should be named the same as origin. That allows an app to run anywhere without anything special in terms of domains when binding to the KV itself.

Signed-off-by: Derek Collison [email protected]

… Put() and Get() with mirrors and across domains, e.g. leafnodes.

Signed-off-by: Derek Collison <[email protected]>
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 85.751% when pulling 1d9796f on kv-mirrors into 888a91d on main.

Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


_, err = kv.PutString("name", "derek")
expectOk(t, err)
_, err = kv.PutString("age", "22")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you wish ;-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants