[FIXED] Examples: Add missing 'stream' and 'durable' params in usage #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also clarify that `stream` parameter is actually needed. Signed-off-by: Ivan Kozlovic <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #821 +/- ##
==========================================
+ Coverage 68.71% 70.44% +1.73%
==========================================
Files 39 47 +8
Lines 15207 15373 +166
Branches 3143 3181 +38
==========================================
+ Hits 10449 10830 +381
+ Misses 1700 1469 -231
- Partials 3058 3074 +16 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
github-actions bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
…' and 'durable' params in usage (#821)
levb
pushed a commit
to levb/nats.c
that referenced
this pull request
Dec 9, 2024
…ats-io#821) Also clarify that `stream` parameter is actually needed. Signed-off-by: Ivan Kozlovic <[email protected]>
|
Cherry-picked into v3.9.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also clarify that
streamparameter is actually needed.Signed-off-by: Ivan Kozlovic [email protected]