[ADDED, BREAKING] Services: queue group now configurable and can be disabled #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #800 +/- ##
==========================================
+ Coverage 68.71% 70.55% +1.83%
==========================================
Files 39 47 +8
Lines 15207 15450 +243
Branches 3143 3181 +38
==========================================
+ Hits 10449 10900 +451
+ Misses 1700 1476 -224
- Partials 3058 3074 +16 ☔ View full report in Codecov by Sentry. |
|
Looking into the test failure, please hold off the review. |
It appears possible that the client exits before the (own) dispatcher thread finishes and quits. Waiting until the "Done" callback is invoked fixes it. Also, since a sub is (often? always?) freed from the own dispatcher thread, use natsThread_Detach rather than natsThread_Join when cleaning up own dispatcher.
levb
commented
Sep 25, 2024
| { | ||
| nats_destroyQueuedMessages(&sub->ownDispatcher.queue); | ||
|
|
||
| if (sub->ownDispatcher.thread != NULL) | ||
| { | ||
| natsThread_Join(sub->ownDispatcher.thread); | ||
| natsThread_Detach(sub->ownDispatcher.thread); |
There was a problem hiding this comment.
@kozlovic this was an oversight on my end in a prior commit, I think. This code can be executed in the dispatch thread itself, so "Join" wouldn't be right. Anyway, this restores the original logic. It did not appear to affect the test failure here, the wait in the test did.
kozlovic
requested changes
Sep 25, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Sep 30, 2024
…up now configurable and can be disabled (#800)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compliance with nats-io/nats-architecture-and-design#239 and nats-io/nats-architecture-and-design#300
One can now customize the queue group used for microservice endpoints, or disable its use.