Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADDED] Support %-encoded username/password in server URLs #765

Merged
merged 8 commits into from
Jun 13, 2024

Merge branch 'lev-fix-JetStreamSubscribeIdleHeartbeat' into lev-url-e…

6c147f4
Select commit
Loading
Failed to load commit list.
Merged

[ADDED] Support %-encoded username/password in server URLs #765

Merge branch 'lev-fix-JetStreamSubscribeIdleHeartbeat' into lev-url-e…
6c147f4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 13, 2024 in 0s

68.73% (+0.02%) compared to 92b9c7d

View this Pull Request on Codecov

68.73% (+0.02%) compared to 92b9c7d

Details

Codecov Report

Attention: Patch coverage is 76.19048% with 5 lines in your changes missing coverage. Please review.

Project coverage is 68.73%. Comparing base (92b9c7d) to head (6c147f4).

Current head 6c147f4 differs from pull request most recent head a1533fc

Please upload reports for the commit a1533fc to get more accurate results.

Files Patch % Lines
src/url.c 76.19% 1 Missing and 4 partials ⚠️
Additional details and impacted files
@@                             Coverage Diff                             @@
##           lev-fix-JetStreamSubscribeIdleHeartbeat     #765      +/-   ##
===========================================================================
+ Coverage                                    68.70%   68.73%   +0.02%     
===========================================================================
  Files                                           39       39              
  Lines                                        15186    15207      +21     
  Branches                                      3139     3143       +4     
===========================================================================
+ Hits                                         10434    10452      +18     
+ Misses                                        1699     1698       -1     
- Partials                                      3053     3057       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.