Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] flapping test: Test_KeyValueMirrorCrossDomains #747

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

levb
Copy link
Collaborator

@levb levb commented Apr 19, 2024

On main:
image

Fixed by retrying until the new value appears. Was unable to get the failure with the fix.

@levb levb requested review from mtmk and kozlovic April 19, 2024 18:48
Copy link
Contributor

@mtmk mtmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@levb levb merged commit 4608e3b into main Apr 19, 2024
2 checks passed
@levb levb deleted the lev-fix-flapping-Test_KeyValueMirrorCrossDomains branch April 19, 2024 21:27
@levb levb removed the cherry-pick label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants