[FIXED] Build: issue on Android with NATS_EXTRA_LIB
#739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A user (@psantiagol) reported an issue (in #64) building on Android due to the use of `NATS_EXTRA_LIB`. This PR skip the definition of this variable if building on Android. Should other users then report that this is breaking their build on Android, we will have to make this a conditional based on a boolean build option. Signed-off-by: Ivan Kozlovic <[email protected]>
With PR nats-io/nats-server#5242 in server code, not providing a MaxDeliver is considered unlimited and should not error out. So fixing test to set MaxDeliver <= to the backoff list to get the expected error. Signed-off-by: Ivan Kozlovic <[email protected]>
levb
pushed a commit
that referenced
this pull request
Apr 12, 2024
* [FIXED] Build: issue on Android with NATS_EXTRA_LIB A user (@psantiagol) reported an issue (in #64) building on Android due to the use of `NATS_EXTRA_LIB`. This PR skip the definition of this variable if building on Android. Should other users then report that this is breaking their build on Android, we will have to make this a conditional based on a boolean build option. Signed-off-by: Ivan Kozlovic <[email protected]> * Fix test JetStreamBackOffRedeliveries With PR nats-io/nats-server#5242 in server code, not providing a MaxDeliver is considered unlimited and should not error out. So fixing test to set MaxDeliver <= to the backoff list to get the expected error. Signed-off-by: Ivan Kozlovic <[email protected]> --------- Signed-off-by: Ivan Kozlovic <[email protected]>
|
Cherry-picked for |
IMO, this is the correct condition. termux-packages was carrying a patch for this issue for 2 years https://github.com/termux/termux-packages/blob/019cdbab029f468c8a370f78b8cdacc1b5dbd24e/packages/libnats-c/CMakeLists.txt.patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user (@psantiagol) reported an issue (in #64) building on Android
due to the use of
NATS_EXTRA_LIB. This PR skip the definition ofthis variable if building on Android. Should other users then report
that this is breaking their build on Android, we will have to make
this a conditional based on a boolean build option.
Also, fixed test JetStreamBackOffRedeliveries.
With PR nats-io/nats-server#5242 in server
code, not providing a MaxDeliver is considered unlimited and should
not error out. So fixing test to set MaxDeliver <= to the backoff
list to get the expected error.
Signed-off-by: Ivan Kozlovic [email protected]