[FIXED] check of the backoff and max delivery configs #6154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luisgustavom1
changed the title
Luisgustavom1
changed the title
Luisgustavom1
force-pushed
the
fix_backoff_and_max_deliver_validation
branch
from
e8ad67c to
cc5735d
Compare
neilalexander
approved these changes
Nov 20, 2024
|
Is |
Match the check of the backoff and maxDeliver configs with the official documentation https://docs.nats.io/nats-concepts/jetstream/consumers#:~:text=The%20sequence%20length,MaxDelivery
Luisgustavom1
force-pushed
the
fix_backoff_and_max_deliver_validation
branch
from
cc5735d to
7470975
Compare
Luisgustavom1
changed the title
Yes, I'm writing one more test case, now everything is done! tks |
neilalexander
added a commit
that referenced
this pull request
Nov 22, 2024
kozlovic
added a commit
to nats-io/nats.c
that referenced
this pull request
Nov 23, 2024
Since this server PR: nats-io/nats-server#6154 the error occurs only if MaxDeliver is specified, but it is strictly lower than BackOff length. So fix the test by lowering it to 1. Signed-off-by: Ivan Kozlovic <[email protected]>
levb
pushed a commit
to nats-io/nats.c
that referenced
this pull request
Nov 24, 2024
Since this server PR: nats-io/nats-server#6154 the error occurs only if MaxDeliver is specified, but it is strictly lower than BackOff length. So fix the test by lowering it to 1. Signed-off-by: Ivan Kozlovic <[email protected]>
levb
pushed a commit
to levb/nats.c
that referenced
this pull request
Dec 9, 2024
Since this server PR: nats-io/nats-server#6154 the error occurs only if MaxDeliver is specified, but it is strictly lower than BackOff length. So fix the test by lowering it to 1. Signed-off-by: Ivan Kozlovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match the check of the backoff and maxDeliver configs with the official documentation -> https://docs.nats.io/nats-concepts/jetstream/consumers#:~:text=The%20sequence%20length,MaxDelivery
Documentation, tell that
Backoffconfig must be less than or equal toMaxDelivery. But we were checking the oppositeSigned-off-by: Luisao [email protected]