Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] mset.noInterest requires write lock #6122

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

MauriceVanVeen
Copy link
Member

mset.noInterest(..) mentions it requires a write lock to be held:

// Check if there is no interest in this sequence number across our consumers.
// The consumer passed is optional if we are processing the ack for that consumer.
// Write lock should be held.
func (mset *stream) noInterest(seq uint64, obs *consumer) bool {
	return !mset.checkForInterest(seq, obs)
}

This wasn't done in cleanupNoInterestMessages.

Signed-off-by: Maurice van Veen [email protected]

@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner November 13, 2024 15:10
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit ffdef99 into main Nov 13, 2024
5 checks passed
@derekcollison derekcollison deleted the maurice/mset-no-interest-write-lock branch November 13, 2024 16:52
neilalexander added a commit that referenced this pull request Nov 19, 2024
Includes the following:

* #6121
* #6122
* #6126
* #6127
* #6128
* #6091
* #6132
* #6133
* #6135

Signed-off-by: Neil Twigg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants