Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] Backoff not respected with multiple inflight redeliveries #6104

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

MauriceVanVeen
Copy link
Member

Resolves #6085

With two messages, one being scheduled to be redelivered after max backoff, and another new message that just came in. The new message would only be redelivered after the max backoff due to the first message having set the timer as such.

Make sure that we can reset the pending timer to trigger earlier in this scenario.

Signed-off-by: Maurice van Veen [email protected]

@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner November 11, 2024 13:13
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 7ac6d48 into main Nov 11, 2024
5 checks passed
@derekcollison derekcollison deleted the maurice/backoff-multiple-inflight-redeliveries branch November 11, 2024 17:12
neilalexander added a commit that referenced this pull request Nov 12, 2024
Includes the following:

* Some tweaks to the NRG test helpers
* #6055
* #6061
* #6065 
* #6041 (but with `math/rand`
instead of `math/rand/v2` due to an older Go version in CI for 2.10.x)
* #6066
* #6067
* #6069
* #6075
* #6082
* #6087
* #6086
* #6088
* #6089
* #6092
* #6096
* #6098
* #6097
* #6105
* #6104
* #6106
* #6109
* #6111
* #6112

Signed-off-by: Neil Twigg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

backoff non respected for some messages retries occuring during the long backoff of another message
3 participants