Fix nil pointer dereference on Placement #5996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check for empty object exposed a lack of check for `*Placement` before accessing its fields. This commit properly fixes it. Signed-off-by: Tomasz Pietrek <[email protected]>
|
think we need coverage of sending empty objects on the other endpoints that might have been relying on filtering out empty fields. also for this one need a test of sending unitialized placement like |
|
Will add a test. Did a brief check of others usages and it seems fine, but will test to be sure. |
Signed-off-by: Tomasz Pietrek <[email protected]>
|
Added a test, but I wonder if it makes sense to have it - empty object test achieves the same as |
Signed-off-by: Tomasz Pietrek <[email protected]>
|
Checked other endpoints that are using new function. We do not have pointers in them. |
|
@Jarema you're right in this case |
neilalexander
pushed a commit
that referenced
this pull request
Oct 15, 2024
The check for empty object exposed a lack of check for `*Placement` before accessing its fields. This commit properly fixes it. Signed-off-by: Tomasz Pietrek <[email protected]> --------- Signed-off-by: Tomasz Pietrek <[email protected]>
neilalexander
added a commit
that referenced
this pull request
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check for empty object exposed a lack of check for
*Placementbefore accessing its fields. This commit properly fixes it.Signed-off-by: Tomasz Pietrek [email protected]