[FIXED] When scaling down a stream make sure consumers are adjusted properly. #5927
+190
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sted and also make sure we do not have orphan consumers. When we scale down a replicated stream, say R5, if it has consumers that are a lower replica count, say R1, they could be placed on the peers that may go away. We need to make sure we properly assign peers and transfer state as needed. Note the consumer state transfer expects the state to be stable, so should be paused. Signed-off-by: Derek Collison <[email protected]>
neilalexander
approved these changes
Sep 25, 2024
| s.Warnf("Did not receive consumer info results for '%s > %s > %s' due to: %s", acc, osa.Config.Name, ca.Name, err) | ||
| } else if ci != nil { | ||
| cca.State = &ConsumerState{ | ||
| Delivered: SequencePair{ |
There was a problem hiding this comment.
Do we need to include the Redelivered state here too?
There was a problem hiding this comment.
We do not have access to that state here.
There was a problem hiding this comment.
So not perfect, and we should revisit for 2.11, but better then what we had for sure.
neilalexander
added a commit
that referenced
this pull request
Sep 25, 2024
Includes: - #5925 - #5926 - #5927 Signed-off-by: Neil Twigg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When scaling down a stream make sure replica count is correct if adjusted and also make sure we do not have orphan consumers.
When we scale down a replicated stream, say R5, if it has consumers that are a lower replica count, say R1, they could be placed on the peers that may go away. We need to make sure we properly assign peers and transfer state as needed.
Note the consumer state transfer expects the state to be stable, so should be paused.
Signed-off-by: Derek Collison [email protected]