Add NumInterest to optimise searching for number of sublist entries
#5918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neil Twigg <[email protected]>
This was referenced Oct 10, 2024
neilalexander
added a commit
that referenced
this pull request
Oct 10, 2024
Includes the following: - #5918 - #5982 - #5983 (although only the 1.22.8 upgrade, since 1.21.x is no longer receiving updates) Signed-off-by: Neil Twigg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some cases where we care about the number of subscriptions on the sublist but don't need the
SublistResults. We can save quite a few allocations on these paths by reusing the match-any logic fromHasInterestto count the number of subs.Signed-off-by: Neil Twigg [email protected]