Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-picks for 2.10.17-RC.5 #5560

Merged
merged 4 commits into from
Jun 18, 2024
Merged

Cherry-picks for 2.10.17-RC.5 #5560

merged 4 commits into from
Jun 18, 2024

Conversation

ken8203 and others added 4 commits June 18, 2024 15:13
…h may already exist. (#5556)

Signed-off-by: Derek Collison <[email protected]>

---------

Signed-off-by: Derek Collison <[email protected]>
Previously we were cleaning up all old ones and doing it in a go routine.
However this could cause multiple go routines to race and delete the wrong snapshot leaving none available.

Signed-off-by: Derek Collison <[email protected]>
@neilalexander neilalexander requested a review from a team as a code owner June 18, 2024 14:15
@neilalexander
Copy link
Member Author

@aricart

server/auth_callout_test.go:1989:19: undefined: ServerAPIClaimUpdateResponse

Is #5555 supposed to be for 2.10.17?

@aricart
Copy link
Member

aricart commented Jun 18, 2024

@neilalexander yes I think Derek wanted to include it - let me see if I can change the test to not rely on that type

@aricart
Copy link
Member

aricart commented Jun 18, 2024

@neilalexander added PR to fix test #5561

Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander
Copy link
Member Author

Excluded #5555 for now as will get the test sorted out for the next RC but we have NGS users blocked on the advisory streams.

@neilalexander neilalexander merged commit 37f8233 into release/v2.10.17 Jun 18, 2024
4 checks passed
@neilalexander neilalexander deleted the neil/21017rc5 branch June 18, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants