[FIXED] Make access to mb's first and last sequence to consistently use atomics. #4744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes data races. Signed-off-by: Derek Collison <[email protected]>
|
Might be, could not remember when they introduced those but looking now is G0 1.19, so we should be good if we want to switch. Eventually I want the top level block selection to not need atomics or locks, but more for 2.11. What alignment issues to you forsee? |
|
I think we are ok alignment wise, but understand what you are saying. I think for now will leave but agree if we keep this direction we should consider. But I think there is a better way for the upper layer indexing and block selection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes data races.
Signed-off-by: Derek Collison [email protected]