Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADDED] Config options to disable MQTT QOS2 support #4705

Merged
merged 3 commits into from
Oct 25, 2023
Merged

[ADDED] Config options to disable MQTT QOS2 support #4705

merged 3 commits into from
Oct 25, 2023

Conversation

levb
Copy link
Contributor

@levb levb commented Oct 25, 2023

Added MQTT config options reject_qos2_publish and downgrade_qos2_subscriptions. When used together, fully disable QOS2 support (effectively going back to v2.9 level of QOS support).

@levb
Added MQTT QOS2 disable config options
b80f006 
Changed: moved MQTT QOS2 disable config options from sess to client

Added tests

Signed-off-by: Lev Brouk <[email protected]>
@levb levb requested a review from a team as a code owner October 25, 2023 12:27
kozlovic
kozlovic requested changes Oct 25, 2023
View reviewed changes
server/opts.go Outdated Show resolved Hide resolved
server/mqtt_test.go Outdated Show resolved Hide resolved
server/opts.go Show resolved Hide resolved
server/mqtt_test.go Show resolved Hide resolved
@derekcollison
Copy link
Member

Where are we on this?

kozlovic
kozlovic approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood for the naming of the options. You can do the other changes (the , _ and the expect disconnect) without adding the new tests, or merge as-is if pressed by time.

server/opts.go Show resolved Hide resolved
@levb
Copy link
Contributor Author

levb commented Oct 25, 2023

@derekcollison finishing the extra tests that @kozlovic requested (I agree, they are needed), give me a few minutes

@levb levb requested a review from kozlovic October 25, 2023 16:12
levb
levb commented Oct 25, 2023
View reviewed changes
server/mqtt.go Show resolved Hide resolved
kozlovic
kozlovic approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small copy/paste issues related to NATS connection and comment, but other than that, LGTM.

server/mqtt_test.go Outdated Show resolved Hide resolved
server/mqtt_test.go Outdated Show resolved Hide resolved
kozlovic
kozlovic approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@levb levb merged commit 3f7ad66 into main Oct 25, 2023
4 checks passed
@levb levb deleted the lev-mqtt-disable-qos2 branch October 25, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kozlovic kozlovic kozlovic approved these changes

@neilalexander neilalexander Awaiting requested review from neilalexander

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@levb @derekcollison @kozlovic