Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record details about the asset a particular raft stream belongs to #4662

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

ripienaar
Copy link
Contributor

I often encounter sisutation where one of the Raft streams are growing out of control or streams that just wont recover correctly, being able to walk backward from these streams back to their managed asset will help a lot with debugging activities

Signed-off-by: R.I.Pienaar [email protected]

I often encounter sisutation where one of the Raft streams are growing
out of control or streams that just wont recover correctly, being able
to walk backward from these streams back to their managed asset will help
a lot with debugging activities

Signed-off-by: R.I.Pienaar <[email protected]>
@ripienaar ripienaar requested a review from a team as a code owner October 15, 2023 12:18
@ripienaar
Copy link
Contributor Author

@wallyqs please let me know your thoughts

Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, agree this would be convenient to check to which stream/consumer a raft group belongs too.

@ripienaar ripienaar requested a review from a team October 17, 2023 09:58
@ripienaar
Copy link
Contributor Author

Added server to approval list now after Wally as Derek asked specifically for Wallys input here.

@derekcollison derekcollison merged commit 80484e9 into nats-io:main Oct 17, 2023
2 checks passed
@ripienaar ripienaar deleted the raft_stream_meta branch October 17, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants