Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a crash in MQTT outgoing PUBREL #4646

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Conversation

levb
Copy link
Contributor

@levb levb commented Oct 11, 2023

This really was a cut/paste/typo error, the else should not have been there. Came up in my testing.

The effect was that when there was a pending PUBREL in JetStream, and a matching client connects - we would sometimes attempt to deliver the PUBREL immediately once connected. cpending was already initialized, but the pubrel map was not (yet).

This really was a cut/paste/typo error.

The effect was that when there was a pending PUBREL in JetStream, we would sometimes attempt to deliver it immediately once the client connected, cpending was already initialized, but the pubrel map was not (yet).
@levb levb requested a review from a team as a code owner October 11, 2023 01:14
@levb levb requested review from kozlovic and a team and removed request for a team October 11, 2023 01:14
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 9a55118 into main Oct 11, 2023
4 checks passed
@derekcollison derekcollison deleted the lev-fix-MQTT-crash branch October 11, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants