Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore subject_transform_dest in stream sourcing #4558

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

neilalexander
Copy link
Member

This is a safer (less lines of code touched) alternative to #4557 for now, which simply ignores the subject_transform_dest field in the API and the stream assignments. We'll still look to merge the other PR to clean up but will do so post-release when we have more time to test it.

Signed-off-by: Neil Twigg [email protected]

@neilalexander neilalexander marked this pull request as ready for review September 19, 2023 15:04
@neilalexander neilalexander requested a review from a team as a code owner September 19, 2023 15:04
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This is much safer approach for now.

@neilalexander neilalexander merged commit ecbfac8 into main Sep 19, 2023
@neilalexander neilalexander deleted the neil/subjecttransformdest branch September 19, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants