Allow more time in TestFileStoreNumPendingLargeNumBlks
#4515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ging on failure Signed-off-by: Neil Twigg <[email protected]>
wallyqs
reviewed
Sep 12, 2023
| @@ -133,6 +135,13 @@ func require_Len(t *testing.T, a, b int) { | |||
| } | |||
| } | |||
|
|
|||
| func require_LessThan[T constraints.Ordered](t *testing.T, a, b T) { | |||
There was a problem hiding this comment.
In a future release when Go 1.22 is out we should change this to be cmp.Ordered which would be included since Go 1.21? https://pkg.go.dev/cmp@master#Ordered
misterpickypants
added a commit
to augustoroman/nats-server
that referenced
this pull request
Oct 25, 2023
A generic test function was introduced in nats-io#4515 using `constraints.Ordered` from golang.org/x/exp/constaints. This unfortunately introduces further transitive dependencies on packages such as golang.org/x/tools which has versions with various breaking changes. This makes it more difficult to pull in nats-server in downstream projects. By inlining the trivial `ordered` definition, we can trim this dependency. An alternative to this change would be to downgrade the required version of golang.org/x/exp since the constraints package has been there (and unchanged) since 2022-02-02. Signed-off-by: Augusto Roman <[email protected]>
derekcollison
added a commit
that referenced
this pull request
Oct 25, 2023
A generic test function was introduced in #4515 using `constraints.Ordered` from golang.org/x/exp/constaints. This unfortunately introduces further transitive dependencies on packages such as golang.org/x/tools which has versions with various breaking changes. This makes it more difficult to pull in nats-server in downstream projects. By inlining the trivial `ordered` definition, we can trim this dependency. An alternative to this change would be to downgrade the required version of golang.org/x/exp since the constraints package has been there (and unchanged) since 2022-02-02. Signed-off-by: Augusto Roman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully de-flake
TestFileStoreNumPendingLargeNumBlksa bit. By adding a newrequire_LessThanhelper function, we also will produce a more meaningful log line that tells us what the bad values were if the test fails.Signed-off-by: Neil Twigg [email protected]