[FIXED] LeafNode: wrong permission check prevented message flow #2455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #2454 Signed-off-by: Ivan Kozlovic <[email protected]>
kozlovic
added a commit
that referenced
this pull request
Aug 24, 2021
This commit simply includes a change to the test that was added for PR #2455 that fixed a similar issue (in deliverMsg). This issue has to do with initial send of subscription interest. Resolves #2469 Signed-off-by: Ivan Kozlovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #1480 was added in v2.2.0, so that matches user report that suggest that things changed compared to pre-2.2.0 releases.
The check for "pubAllowed" when client is a LEAF was added in that PR. Only the PUB permissions were checked regardless of the type of leaf connection (hub or spoke). In PR 1480, the check was done only for spoke but then was changed to perform pub check as long as client is LEAF: 3729552
I think that we need to distinguish if the connection is hub, check subscribe permissions, if spoke, pub permissions. I have added a test that reproduces the user report
TestLeafNodeOperatorAndPermissionsthat seem to be fixed with the proposed change.Resolves #2454
Signed-off-by: Ivan Kozlovic [email protected]