PR feedback: remove the field completely and don't test to check if i…

…t was specified in the request
nats-io · Sep 19, 2023 · f336a31 · f336a31
1 parent d344a26
commit f336a31
Showing 1 changed file with 7 additions and 17 deletions.
diff --git a/server/stream.go b/server/stream.go
@@ -191,16 +191,12 @@ type StreamSourceInfo struct {
 
 // StreamSource dictates how streams can source from other streams.
 type StreamSource struct {
-	Name          string     `json:"name"`
-	OptStartSeq   uint64     `json:"opt_start_seq,omitempty"`
-	OptStartTime  *time.Time `json:"opt_start_time,omitempty"`
-	FilterSubject string     `json:"filter_subject,omitempty"`
-	// Do not expose SubjectTransformDest in the client libraries
-	// it is here because it was enabled for a while in the 2.10 beta but is now removed
-	// and there is now a check to error out if it is provided in the request
-	SubjectTransformDest string                   `json:"subject_transform_dest,omitempty"`
-	SubjectTransforms    []SubjectTransformConfig `json:"subject_transforms,omitempty"`
-	External             *ExternalStream          `json:"external,omitempty"`
+	Name              string                   `json:"name"`
+	OptStartSeq       uint64                   `json:"opt_start_seq,omitempty"`
+	OptStartTime      *time.Time               `json:"opt_start_time,omitempty"`
+	FilterSubject     string                   `json:"filter_subject,omitempty"`
+	SubjectTransforms []SubjectTransformConfig `json:"subject_transforms,omitempty"`
+	External          *ExternalStream          `json:"external,omitempty"`
 
 	// Internal
 	iname string // For indexing when stream names are the same for multiple sources.
@@ -1257,10 +1253,7 @@ func (s *Server) checkStreamCfg(config *StreamConfig, acc *Account) (StreamConfi
 		if len(cfg.Sources) > 0 {
 			return StreamConfig{}, NewJSMirrorWithSourcesError()
 		}
-		if cfg.Mirror.SubjectTransformDest != _EMPTY_ {
-			return StreamConfig{}, NewJSStreamInvalidConfigError(fmt.Errorf("stream mirror can not have a single subject_transform_destination"))
-		}
-		if (cfg.Mirror.FilterSubject != _EMPTY_ || cfg.Mirror.SubjectTransformDest != _EMPTY_) && len(cfg.Mirror.SubjectTransforms) != 0 {
+		if cfg.Mirror.FilterSubject != _EMPTY_ && len(cfg.Mirror.SubjectTransforms) != 0 {
 			return StreamConfig{}, NewJSMirrorMultipleFiltersNotAllowedError()
 		}
 		// Check subject filters overlap.
@@ -1322,9 +1315,6 @@ func (s *Server) checkStreamCfg(config *StreamConfig, acc *Account) (StreamConfi
 		if !isValidName(src.Name) {
 			return StreamConfig{}, NewJSSourceInvalidStreamNameError()
 		}
-		if src.SubjectTransformDest != _EMPTY_ {
-			return StreamConfig{}, NewJSStreamInvalidConfigError(fmt.Errorf("stream sources can not have a single subject_transform_destination"))
-		}
 		if _, ok := iNames[src.composeIName()]; !ok {
 			iNames[src.composeIName()] = struct{}{}
 		} else {