Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only include file with external ip if AdvertiseExternalIP is true. #282

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Only include file with external ip if AdvertiseExternalIP is true. #282

merged 1 commit into from
Aug 24, 2020

Conversation

mtryfoss
Copy link
Contributor

If AdvertiseExternalIP is false on gateway configured cluster, startup fails.

This will fix #279

… AdvertiseExternalIP is false on gateway configured cluster, startup fails.
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wallyqs wallyqs merged commit 4e2be5e into nats-io:master Aug 24, 2020
@mtryfoss mtryfoss deleted the feature_gateway_without_advertiseexternalip branch December 18, 2020 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nats-Pod crashes when deploying nats cluster with super cluster / gateway configuration
2 participants