Reverse order of CRD init operations #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyqs
reviewed
Apr 1, 2019
wallyqs
reviewed
Apr 1, 2019
|
Thanks @schancel for the PR! Left a couple of suggestions that I think will fix the error in the build. |
|
@wallyqs Should be fixed. Any chance you're willing to switch to |
schancel
commented
Apr 1, 2019
pkg/util/kubernetes/crd.go
Outdated
| // Attempt to update the CRD by setting its spec to the expected value. | ||
| d.Spec = crd.Spec | ||
| if _, err := extsClient.ApiextensionsV1beta1().CustomResourceDefinitions().Update(d); err != nil { | ||
| // Registration failed |
There was a problem hiding this comment.
Actually this is silly...
This commit reverses the order of CRD init operations. The reason for doing CRD init operations in this new order, is so that k8s admins can manually create the expected CRDs. By creating the CRDs by hand, create CRD permission does not need to be granted to the nats-operator SA. Only read permission is required.
|
Sorry about the inconvenience, will switch to use go modules after this. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reverses the order of CRD init operations. The reason for
doing CRD init operations in this new order, is so that k8s admins
can manually create the expected CRDs. By creating the CRDs by hand,
create CRD permission does not need to be granted to the nats-operator SA.
Only read permission is required.