Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow override name of resources #62

Merged
merged 1 commit into from
Jun 7, 2020
Merged

Allow override name of resources #62

merged 1 commit into from
Jun 7, 2020

Conversation

malvex
Copy link
Contributor

@malvex malvex commented Jun 7, 2020

Hi, I was trying to use helm charts as requirement for my chart like this:

dependencies:
  - name: nats
    repository: https://nats-io.github.io/k8s/helm/charts/
    version: 0.4.0
  - name: stan
    repository: https://nats-io.github.io/k8s/helm/charts/
    version: 0.4.0

However because .Release.Name is used as a name for all resources it fails with "resource already exists" error because both nats and stan chart is trying to create resource MY-RELEASE-config and the rest.

This change doesn't break anything and allows to override name of each chart with values.yaml. It is widely used approach.

Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks for the PR! LGTM

@wallyqs wallyqs merged commit 469fc58 into nats-io:master Jun 7, 2020
@palsivertsen
Copy link

I suspect this broke all the charts over at https://hub.helm.sh/charts/nats

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants