Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix location of server binary in preStop command #61

Merged
merged 1 commit into from
Jun 9, 2020

Conversation

jdolce
Copy link
Contributor

@jdolce jdolce commented Jun 7, 2020

Server was not entering lame duck mode when the pod was terminated because the path to the nats-server binary was incorrect.

CC: @wallyqs

Server was not entering lame duck mode when the pod was terminated because the path to the nats-server binary was incorrect.
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@wallyqs wallyqs merged commit 1cbe59d into nats-io:master Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants