helm: stan, volumeClaim configuration #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @orefalo I tried locally didn't get an error but maybe have introduced an issue during an upgrade, I will take another look |
|
Hey @samstride sorry for the wait, I'm aiming at releasing a new version the charts in a couple of days. |
|
Thanks, will try again in a few days (with the new chart) and provide the complete log. |
| volume: | ||
| enabled: true | ||
| mount: /data/stan | ||
| storageSize: 100Gi |
There was a problem hiding this comment.
1Gi -> 100Gi. Sounds good... Were there any issues?
There was a problem hiding this comment.
I think I will lower this down back to 1Gi by default otherwise will get an error when upgrading since cannot be changed on the fly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to use the volumeClaimTemplate for the logs and the store. Otherwise, the cluster cannot recover their state, see nats-io/nats-streaming-server#547
https://github.com/nats-io/nats-streaming-server/pull/548/files
Also, the support for choosing the storageClass has been introducing, and the default size has been changed to something more performance since usually small disk have low I/O in cloud platforms.