Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort a refresh if the previous refresh is still in progress #148

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

canton7
Copy link
Collaborator

@canton7 canton7 commented Apr 13, 2023

Also improve the logging in this area. With multiple inverters it was hard to tell which inverter a log message related to sometimes

Fixes: #141

@nathanmarlor nathanmarlor added the bug Something isn't working label Apr 17, 2023
@nathanmarlor
Copy link
Owner

@canton7 can you take a look at the merge conflicts please?

@canton7 canton7 marked this pull request as draft April 17, 2023 10:01
@canton7 canton7 marked this pull request as ready for review April 17, 2023 10:03
Also improve the logging in this area. With multiple inverters it was hard
to tell which inverter a log message related to sometimes

Fixes: nathanmarlor#141
@canton7
Copy link
Collaborator Author

canton7 commented Apr 17, 2023

That was painful... There we go!

@nathanmarlor nathanmarlor merged commit e3d1ba0 into nathanmarlor:main Apr 17, 2023
@canton7 canton7 deleted the bugfix/overlapping-polls branch May 4, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If poll speed is too high, previous and next reads overlap
2 participants