New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fall back to chunked mode for unknown frame buffer sizes #62

Merged

nathanbabcock merged 1 commit into main from fix/bytes-per-frame-fallback

Nov 6, 2024

Owner

nathanbabcock commented Nov 6, 2024

This PR revamps spawn_stdout_thread to make the following behavior more explicit and clear:

If a frame buffer size can't be calculated, fall back to the variable size "chunked mode"
Allocate a single buffer for chunked mode instead of mixing it in with the known-size frame buffers
Check for a previously implicit assumption: if multiple outputs are interleaved on stdout, they must share the same framerate. Otherwise, they also fall back to chunked mode.

Also adds some unit tests, including coverage for the bug fixed by #61


          fix: fall back to chunked mode for unknown frame buffer sizes

5c2c3c3

nathanbabcock merged commit 03c81aa into main

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet