Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a separate parsing of fatal error logs so that they can be handled separately. I initially did this by adding a
FfmpegEvent::LogFatal
but in the last commit I changed this to make it a singleFfmpegEvent::Log
with aLogLevel
field. I don't have a strong opinion in either direction so I'll leave the decision up to you.I also changed the log parsing logic to check if a log line contains the log level in square braces (instead of starting with it) because I encountered a few logs like this that would otherwise be parsed incorrectly:
I didn't add tests because there currently aren't any for the
parse_next_event
function and I didn't know how you want that set up.