Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tar dependency and used platform specific dependencies for different formats #51

Merged
merged 13 commits into from
Oct 16, 2024

Conversation

VirtualPirate
Copy link
Contributor

No description provided.

nathanbabcock
nathanbabcock previously approved these changes Oct 15, 2024
Copy link
Owner

@nathanbabcock nathanbabcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VirtualPirate Works like a charm locally for me on Windows, and CI passed on all other platforms. Love how concise it is, too.

Thanks for your work on this and the previous PR. Please feel free to merge :)

@nathanbabcock nathanbabcock self-requested a review October 15, 2024 19:55
@nathanbabcock nathanbabcock dismissed their stale review October 15, 2024 19:56

one followup comment

Cargo.toml Outdated Show resolved Hide resolved
@VirtualPirate
Copy link
Contributor Author

@nathanbabcock you can merge it, if everything looks fine. I don't have write access to the repo

@nathanbabcock nathanbabcock merged commit 0bb321e into nathanbabcock:main Oct 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants