-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mac M1 support #16
Merged
Merged
Mac M1 support #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanbabcock
force-pushed
the
feat/mac-m1
branch
from
September 17, 2023 21:26
f1a122f
to
5869b07
Compare
nathanbabcock
force-pushed
the
feat/mac-m1
branch
from
September 17, 2023 21:27
5869b07
to
94d81af
Compare
jt-wang
suggested changes
Sep 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nathanbabcock Thanks Nathan!
~/github/ffmpeg-sidecar main v0.4.1 git checkout feat/mac-m1
branch 'feat/mac-m1' set up to track 'origin/feat/mac-m1'.
Switched to a new branch 'feat/mac-m1'
~/github/ffmpeg-sidecar cargo run --example download_ffmpeg
Compiling ffmpeg-sidecar v0.5.0 (~/projects/ffmpeg-sidecar)
Finished dev [unoptimized + debuginfo] target(s) in 1.24s
Running `target/debug/examples/download_ffmpeg`
FFmpeg is already installed! 🎉
For demo purposes, we'll re-download and unpack it anyway.
TIP: Use `auto_download()` to skip manual customization.
Error: Error { message: "Downloads must be manually provided for non-x86_64 architectures", source: None }
I believe the Error is from line 18,
pub fn ffmpeg_manifest_url() -> Result<&'static str> {
if cfg!(not(target_arch = "x86_64")) {
return Err(Error::msg(
"Downloads must be manually provided for non-x86_64 architectures",
));
}
because ffmpeg_manifest_url
is called in line 147,
pub fn check_latest_version() -> Result<String> {
let string = curl(ffmpeg_manifest_url()?)?;
if cfg!(target_os = "windows") {
Ok(string)
} else if cfg!(target_os = "macos") {
Ok(parse_macos_version(&string).ok_or("failed to parse version number (macos variant)")?)
} else if cfg!(target_os = "linux") {
Ok(parse_linux_version(&string).ok_or("failed to parse version number (linux variant)")?)
} else {
Err(Error::msg("Unsupported platform"))
}
}
@jt-wang you are completely correct of course, and my apologies for taking a while to update the PR. Give it another go now with the same command. |
not supported by setup-ffmpeg dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15