feat: Added wait method on FfmpegChild #14
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every call to
spawn
without a call on the Result towait
results in a zombie process that stays until the main thread exits. This lead to OS issues with large datasets because it is possible that all PID's are used by the zombies.This PR exposes the
wait
method ofstd::process::Child
to the user, giving the possibility to wait for the process to complete and clean up properly.It has only been tested on Linux.
I am happy to further adjust the code to your coding/documentation style requirements.
Best regards,
Lewin